Conversation
Add support for saving multiple login profiles and switching between them from the sidebar account menu. Temporarily disable Windows dictation in builds to unblock release packaging. Co-authored-by: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70b819f680
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| setSavedProfilesLoading(false); | ||
| return; | ||
| } | ||
| void reloadSavedProfiles(activeWorkspaceId); |
There was a problem hiding this comment.
This effect always calls listSavedAuthProfiles whenever a workspace is active, but the backend command explicitly returns an error in remote mode (saved_auth_profiles_list returns “not supported in remote mode”). In remote sessions, that means opening/switching workspaces now triggers avoidable error toasts even though account switching itself is otherwise supported, so remote users get a persistent noisy failure introduced by this feature.
Useful? React with 👍 / 👎.
| const response = await listSavedAuthProfiles(workspaceId); | ||
| setSavedProfiles(normalizeSavedProfiles(response)); |
There was a problem hiding this comment.
reloadSavedProfiles writes results directly to shared state without checking that the response still matches the currently active workspace. If a user switches workspaces quickly, an older request can resolve last and overwrite the newer workspace’s profiles, leaving the menu showing the wrong accounts (and potentially attempting activation with IDs from a different workspace) until another refresh happens.
Useful? React with 👍 / 👎.
1 participant
What changed
Switch accountNotes