fix(perps): deposit/withdraw header by aganglada · Pull Request #41572 · MetaMask/metamask-extension

aganglada · 2026-04-08T15:30:28Z

Description

The Perps withdraw page was using PerpsWalletAccountHeader (the account avatar + name row) as its page header, which was inconsistent with the deposit confirmation flow that already shows a clean back-arrow + centred title header.

Previously, a workaround (FORCE_WALLET_INITIATED_HEADER_TYPES) was added to the confirmations header system to force WalletInitiatedHeader for perpsWithdraw transactions. Because the withdraw flow lives on its own dedicated route (/perps/withdraw) rather than inside the confirmations flow, this approach was fragile and required patching unrelated confirmation infrastructure.

This PR:

Replaces PerpsWalletAccountHeader in perps-withdraw-page.tsx with an inline header that matches the deposit style: back button on the left, "Withdraw" title centred, and a 32 px spacer on the right to keep the title visually centred.
Removes the FORCE_WALLET_INITIATED_HEADER_TYPES constant and its associated logic from header.tsx, and removes the perpsWithdraw handling from wallet-initiated-header.tsx, cleaning up the confirmation header system.
Updates and adds unit tests: removes the now-dead PerpsWalletAccountHeader mock, adds tests for the new back button (data-testid="perps-withdraw-back-button") and header title (data-testid="perps-withdraw-header-title").

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Open the MetaMask extension and navigate to the Perps section.
Click Withdraw to open the withdraw page.
Verify the page header shows a back arrow on the left, the title "Withdraw" centred, and no Advanced icon on the right.
Click the back arrow and confirm it navigates back to the previous page (Perps home).
Complete a withdrawal and confirm the flow behaves normally end-to-end.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes confirmation header selection and back-button behavior for perpsDeposit, which could impact how users navigate out of a deposit confirmation. Withdraw page header is refactored to a new inline layout, so UI regressions are possible but scope is limited.

Overview
Perps deposit confirmations now use the alternate confirmation header path for TransactionType.perpsDeposit, showing a custom title (perpsDepositFundsTitle), handling back navigation via onCancel({ navigateBackToPreviousPage: true }), and hiding AdvancedDetailsButton (replaced with a 32px spacer).

Perps withdraw page replaces the PerpsWalletAccountHeader strip with an inline header (back arrow, centered perpsWithdrawFundsTitle, right-side spacer) and adds/updates tests and i18n strings for the new header titles; the removed PerpsWalletAccountHeader component and its tests are deleted.

^{Reviewed by Cursor Bugbot for commit d4be831. Bugbot is set up for automated code reviews on this repo. Configure here.}

github-actions · 2026-04-08T15:31:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbotv2 · 2026-04-08T15:31:57Z

✨ Files requiring CODEOWNER review ✨

✅ @MetaMask/confirmations (3 files, +60 -2)

📁 ui/
- 📁 pages/
  - 📁 confirmations/
    - 📁 components/
      - 📁 confirm/
        
        📁 header/
        
        📄 header.tsx +1 -0
        
        📄 wallet-initiated-header.test.tsx +47 -0
        
        📄 wallet-initiated-header.tsx +12 -2

👨‍🔧 @MetaMask/perps (5 files, +54 -166)

📁 ui/
- 📁 components/
  - 📁 app/
    - 📁 perps/
      - 📁 perps-wallet-account-header/
        
        📄 index.ts +0 -1
        
        📄 perps-wallet-account-header.test.tsx +0 -21
        
        📄 perps-wallet-account-header.tsx +0 -136
- 📁 pages/
  - 📁 perps/
    - 📄 perps-withdraw-page.test.tsx +24 -6
    - 📄 perps-withdraw-page.tsx +30 -2

metamaskbotv2 · 2026-04-08T16:22:27Z

Builds ready [a4ae8e6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24144485314 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -16%
↓ loadNewAccount/total: -16%
↓ bridgeUserActions/bridge_load_asset_picker: -33%
↓ bridgeUserActions/total: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.4s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/domContentLoaded: -11%
↑ startupStandardHome/domInteractive: +13%
↑ startupStandardHome/backgroundConnect: +16%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -14%
↑ startupStandardHome/setupStore: +14%
↓ startupPowerUserHome/domInteractive: -18%
↑ startupPowerUserHome/backgroundConnect: +81%
↑ startupPowerUserHome/setupStore: +17%
↓ startupPowerUserHome/numNetworkReqs: -43%
↓ startupStandardHome/uiStartup: -10%
↓ startupStandardHome/load: -10%
↓ startupStandardHome/backgroundConnect: -27%
↓ startupStandardHome/firstReactRender: -17%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -14%
↑ startupPowerUserHome/numNetworkReqs: +44%
↓ startupStandardHome/domInteractive: -58%
↑ startupStandardHome/initialActions: +25%
↑ startupStandardHome/setupStore: +21%
↓ startupPowerUserHome/uiStartup: -11%
↓ startupPowerUserHome/backgroundConnect: -26%
↑ startupPowerUserHome/firstReactRender: +11%
↑ startupPowerUserHome/setupStore: +39%
↓ startupStandardHome/domInteractive: -34%
↓ startupStandardHome/backgroundConnect: -10%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -57%
↓ startupStandardHome/numNetworkReqs: -13%
↓ startupPowerUserHome/backgroundConnect: -20%
↓ startupPowerUserHome/setupStore: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 712ms
🔴 startupPowerUserHome/INP: p75 704ms
🟡 startupPowerUserHome/LCP: p75 3.4s
🟡 startupPowerUserHome/LCP: p75 3.7s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -84%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -44%
↓ onboardingImportWallet/doneButtonToHomeScreen: -73%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +24%
↓ onboardingImportWallet/total: -39%
↓ onboardingNewWallet/srpButtonToPwForm: -79%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -69%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -12%
↓ onboardingNewWallet/doneButtonToAssetList: -31%
↓ onboardingNewWallet/total: -31%
↓ assetDetails/assetClickToPriceChart: -48%
↓ assetDetails/total: -48%
↓ solanaAssetDetails/assetClickToPriceChart: -71%
↓ solanaAssetDetails/total: -71%
↑ importSrpHome/loginToHomeScreen: +12%
↓ importSrpHome/openAccountMenuAfterLogin: -70%
↓ importSrpHome/homeAfterImportWithNewWallet: -70%
↓ importSrpHome/total: -61%
↓ sendTransactions/openSendPageFromHome: -22%
↓ sendTransactions/selectTokenToSendFormLoaded: -29%
↑ sendTransactions/reviewTransactionToConfirmationPage: +34%
↑ sendTransactions/total: +31%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 208ms
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/FCP: p75 2.6s
🟡 sendTransactions/INP: p75 240ms
🟡 sendTransactions/FCP: p75 2.4s
🟡 swap/FCP: p75 2.4s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -4.65 KiB (-0.06%)
common: 120 Bytes (0%)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3daa112. Configure here.}

ui/pages/perps/perps-withdraw-page.tsx

metamaskbotv2 · 2026-04-08T17:25:40Z

Builds ready [3daa112]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24147296854 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -13%
↓ loadNewAccount/total: -13%
↓ bridgeUserActions/bridge_load_asset_picker: -28%
↓ bridgeUserActions/total: -11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.6s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/load: -11%
↓ startupStandardHome/domContentLoaded: -13%
↑ startupStandardHome/backgroundConnect: +14%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -16%
↑ startupStandardHome/setupStore: +20%
↓ startupStandardHome/numNetworkReqs: -18%
↓ startupPowerUserHome/domInteractive: -10%
↑ startupPowerUserHome/backgroundConnect: +99%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -53%
↓ startupStandardHome/uiStartup: -11%
↓ startupStandardHome/backgroundConnect: -32%
↓ startupStandardHome/firstReactRender: -20%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -13%
↑ startupPowerUserHome/setupStore: +16%
↑ startupPowerUserHome/numNetworkReqs: +25%
↓ startupStandardHome/domInteractive: -23%
↑ startupStandardHome/initialActions: +25%
↑ startupStandardHome/setupStore: +14%
↓ startupStandardHome/numNetworkReqs: -11%
↓ startupPowerUserHome/uiStartup: -12%
↓ startupPowerUserHome/domInteractive: -11%
↓ startupPowerUserHome/backgroundConnect: -30%
↑ startupPowerUserHome/setupStore: +48%
↓ startupStandardHome/domInteractive: -24%
↓ startupStandardHome/backgroundConnect: -12%
↓ startupStandardHome/initialActions: -44%
↓ startupStandardHome/setupStore: -57%
↓ startupStandardHome/numNetworkReqs: -13%
↓ startupPowerUserHome/backgroundConnect: -23%
↓ startupPowerUserHome/setupStore: -25%
↓ startupPowerUserHome/numNetworkReqs: -14%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 728ms
🔴 startupPowerUserHome/INP: p75 720ms
🟡 startupPowerUserHome/LCP: p75 3.5s
🟡 startupPowerUserHome/INP: p75 240ms
🟡 startupPowerUserHome/LCP: p75 3.5s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -85%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -46%
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +32%
↓ onboardingImportWallet/total: -42%
↓ onboardingNewWallet/srpButtonToPwForm: -79%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -70%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -19%
↓ onboardingNewWallet/doneButtonToAssetList: -28%
↓ onboardingNewWallet/total: -28%
↓ assetDetails/assetClickToPriceChart: -45%
↓ assetDetails/total: -45%
↓ solanaAssetDetails/assetClickToPriceChart: -73%
↓ solanaAssetDetails/total: -73%
↓ importSrpHome/openAccountMenuAfterLogin: -75%
↓ importSrpHome/homeAfterImportWithNewWallet: -70%
↓ importSrpHome/total: -61%
↓ sendTransactions/openSendPageFromHome: -32%
↓ sendTransactions/selectTokenToSendFormLoaded: -30%
↑ sendTransactions/reviewTransactionToConfirmationPage: +34%
↑ sendTransactions/total: +30%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +32%
↑ swap/total: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/INP: p75 232ms
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/INP: p75 224ms
🟡 sendTransactions/FCP: p75 2.6s
🟡 swap/FCP: p75 2.6s
🟡 swap/LCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -4.65 KiB (-0.06%)
common: 120 Bytes (0%)

metamaskbotv2 · 2026-04-08T18:17:18Z

Builds ready [21b086f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24149571767 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -16%
↓ loadNewAccount/total: -16%
↓ bridgeUserActions/bridge_load_asset_picker: -31%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/domContentLoaded: -11%
↑ startupStandardHome/domInteractive: +13%
↑ startupStandardHome/backgroundConnect: +17%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -14%
↓ startupPowerUserHome/uiStartup: -23%
↓ startupPowerUserHome/domInteractive: -12%
↑ startupPowerUserHome/backgroundConnect: +61%
↑ startupPowerUserHome/setupStore: +28%
↓ startupPowerUserHome/numNetworkReqs: -29%
↓ startupStandardHome/uiStartup: -14%
↓ startupStandardHome/load: -14%
↓ startupStandardHome/domContentLoaded: -13%
↓ startupStandardHome/backgroundConnect: -36%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/loadScripts: -13%
↓ startupStandardHome/setupStore: -14%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -29%
↑ startupPowerUserHome/numNetworkReqs: +10%
↓ startupStandardHome/domInteractive: -23%
↑ startupStandardHome/initialActions: +25%
↓ startupPowerUserHome/uiStartup: -10%
↓ startupPowerUserHome/backgroundConnect: -27%
↓ startupPowerUserHome/setupStore: -25%
↓ startupStandardHome/domInteractive: -30%
↓ startupStandardHome/backgroundConnect: -19%
↑ startupStandardHome/initialActions: +11%
↓ startupStandardHome/setupStore: -60%
↓ startupStandardHome/numNetworkReqs: -13%
↓ startupPowerUserHome/backgroundConnect: -30%
↑ startupPowerUserHome/setupStore: +14%
↓ startupPowerUserHome/numNetworkReqs: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 728ms
🔴 startupPowerUserHome/INP: p75 712ms
🟡 startupPowerUserHome/LCP: p75 3.5s
🟡 startupPowerUserHome/INP: p75 264ms
🟡 startupPowerUserHome/LCP: p75 3.8s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -84%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -39%
↓ onboardingImportWallet/doneButtonToHomeScreen: -75%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +33%
↓ onboardingImportWallet/total: -42%
↓ onboardingNewWallet/srpButtonToPwForm: -76%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -67%
↓ onboardingNewWallet/agreeButtonToOnboardingSuccess: -28%
↓ onboardingNewWallet/doneButtonToAssetList: -38%
↓ onboardingNewWallet/total: -37%
↓ assetDetails/assetClickToPriceChart: -46%
↓ assetDetails/total: -46%
↓ solanaAssetDetails/assetClickToPriceChart: -67%
↓ solanaAssetDetails/total: -67%
↓ importSrpHome/openAccountMenuAfterLogin: -77%
↓ importSrpHome/homeAfterImportWithNewWallet: -76%
↓ importSrpHome/total: -66%
↓ sendTransactions/openSendPageFromHome: -20%
↓ sendTransactions/selectTokenToSendFormLoaded: -22%
↑ sendTransactions/reviewTransactionToConfirmationPage: +38%
↑ sendTransactions/total: +36%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 216ms
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.5s
🟡 importSrpHome/FCP: p75 2.4s
🟡 sendTransactions/INP: p75 240ms
🟡 sendTransactions/FCP: p75 2.5s
🟡 sendTransactions/LCP: p75 2.5s
🟡 swap/FCP: p75 2.5s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -4.65 KiB (-0.06%)
common: 120 Bytes (0%)

sonarqubecloud · 2026-04-09T08:17:16Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

metamaskbotv2 · 2026-04-09T08:37:38Z

Builds ready [d4be831]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
webpack builds: chrome, firefox
webpack builds (beta): chrome, firefox
webpack builds (flask): chrome, firefox
webpack builds (test): chrome, firefox
webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21
- content-script: 0
- offscreen: 0

⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 12 warn · 🔴 0 fail)

Baseline (latest main): f34f804 | Date: 9/10/58222 | Pipeline: 24179466865 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-browserify
loadNewAccount 🟡 [Show logs]
confirmTx 🟡 [Show logs]
bridgeUserActions 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/load_new_account: -18%
↓ loadNewAccount/total: -18%
↓ bridgeUserActions/bridge_load_asset_picker: -50%
↓ bridgeUserActions/bridge_search_token: -16%
↓ bridgeUserActions/total: -22%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 loadNewAccount/FCP: p75 2.5s
🟡 confirmTx/FCP: p75 2.5s
🟡 bridgeUserActions/FCP: p75 2.5s

Startup Benchmarks · Samples: 100

Benchmark chrome-browserify chrome-webpack firefox-browserify firefox-webpack
startupStandardHome 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs] 🟢 [Show logs]
startupPowerUserHome 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs] 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ startupStandardHome/load: -12%
↓ startupStandardHome/domContentLoaded: -13%
↑ startupStandardHome/backgroundConnect: +14%
↓ startupStandardHome/initialActions: -38%
↓ startupStandardHome/loadScripts: -17%
↑ startupPowerUserHome/backgroundConnect: +98%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -52%
↓ startupStandardHome/uiStartup: -10%
↑ startupStandardHome/firstPaint: +40%
↓ startupStandardHome/backgroundConnect: -29%
↓ startupStandardHome/firstReactRender: -24%
↓ startupStandardHome/numNetworkReqs: -29%
↓ startupPowerUserHome/domInteractive: -13%
↓ startupPowerUserHome/numNetworkReqs: -16%
↓ startupStandardHome/domInteractive: -57%
↑ startupStandardHome/initialActions: +25%
↓ startupStandardHome/numNetworkReqs: -16%
↓ startupPowerUserHome/uiStartup: -17%
↓ startupPowerUserHome/domInteractive: -13%
↓ startupPowerUserHome/backgroundConnect: -46%
↓ startupStandardHome/domInteractive: -36%
↓ startupStandardHome/backgroundConnect: -13%
↑ startupStandardHome/initialActions: +11%
↓ startupStandardHome/setupStore: -54%
↓ startupStandardHome/numNetworkReqs: -13%
↓ startupPowerUserHome/domInteractive: -23%
↓ startupPowerUserHome/backgroundConnect: -40%
↓ startupPowerUserHome/loadScripts: -11%
↑ startupPowerUserHome/setupStore: +22%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 720ms
🔴 startupPowerUserHome/INP: p75 752ms
🟡 startupPowerUserHome/LCP: p75 3.4s
🟡 startupPowerUserHome/LCP: p75 3.7s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-browserify
onboardingImportWallet 🟢 [Show logs]
onboardingNewWallet 🟢 [Show logs]
assetDetails 🟡 [Show logs]
solanaAssetDetails 🟡 [Show logs]
importSrpHome 🟡 [Show logs]
sendTransactions 🟡 [Show logs]
swap 🟡 [Show logs]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/srpButtonToSrpForm: -85%
↓ onboardingImportWallet/metricsToWalletReadyScreen: -27%
↓ onboardingImportWallet/doneButtonToHomeScreen: -76%
↑ onboardingImportWallet/openAccountMenuToAccountListLoaded: +34%
↓ onboardingImportWallet/total: -41%
↓ onboardingNewWallet/srpButtonToPwForm: -78%
↓ onboardingNewWallet/skipBackupToMetricsScreen: -68%
↓ onboardingNewWallet/doneButtonToAssetList: -25%
↓ onboardingNewWallet/total: -27%
↓ assetDetails/assetClickToPriceChart: -46%
↓ assetDetails/total: -46%
↓ solanaAssetDetails/assetClickToPriceChart: -75%
↓ solanaAssetDetails/total: -75%
↓ importSrpHome/openAccountMenuAfterLogin: -71%
↓ importSrpHome/homeAfterImportWithNewWallet: -70%
↓ importSrpHome/total: -61%
↓ sendTransactions/selectTokenToSendFormLoaded: -25%
↑ sendTransactions/reviewTransactionToConfirmationPage: +35%
↑ sendTransactions/total: +32%
↓ swap/openSwapPageFromHome: -96%
↑ swap/fetchAndDisplaySwapQuotes: +31%
↑ swap/total: +11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 assetDetails/INP: p75 224ms
🟡 assetDetails/FCP: p75 2.5s
🟡 solanaAssetDetails/FCP: p75 2.4s
🟡 importSrpHome/FCP: p75 2.5s
🟡 sendTransactions/INP: p75 240ms
🟡 sendTransactions/FCP: p75 2.6s
🟡 swap/FCP: p75 2.6s

Dapp Page Load Benchmarks · Samples: 100

Benchmark chrome-browserify
dappPageLoad 🟢 [Show logs]

Bundle size diffs [🚀 Bundle size reduced!]

background: 58 Bytes (0%)
ui: -2.76 KiB (-0.03%)
common: 123 Bytes (0%)

aganglada temporarily deployed to pr-comment April 8, 2026 15:31 — with GitHub Actions Inactive

github-actions bot added the size-S label Apr 8, 2026

aganglada self-assigned this Apr 8, 2026

aganglada added the team-perps Perps team label Apr 8, 2026

aganglada marked this pull request as ready for review April 8, 2026 15:41

aganglada requested review from a team as code owners April 8, 2026 15:41

aganglada temporarily deployed to pr-comment April 8, 2026 15:43 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 8, 2026 15:45 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 8, 2026 16:17 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 8, 2026 16:44 — with GitHub Actions Inactive

github-actions bot added size-M and removed size-S labels Apr 8, 2026

cursor bot reviewed Apr 8, 2026

View reviewed changes

ui/pages/perps/perps-withdraw-page.tsx Show resolved Hide resolved

aganglada temporarily deployed to pr-comment April 8, 2026 17:20 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 8, 2026 17:36 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 8, 2026 18:06 — with GitHub Actions Inactive

aganglada added 4 commits April 9, 2026 10:01

fix(perps): deposit/withdraw header

bc44cd0

chore: fix lint

965c8a0

chore: more test

291f633

chore: remove dead code

d4be831

aganglada force-pushed the fix/deposit-withdraw-header-perps branch from 21b086f to d4be831 Compare April 9, 2026 08:03

aganglada temporarily deployed to pr-comment April 9, 2026 08:03 — with GitHub Actions Inactive

aganglada temporarily deployed to pr-comment April 9, 2026 08:32 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(perps): deposit/withdraw header#41572

fix(perps): deposit/withdraw header#41572
aganglada wants to merge 4 commits intomainfrom
fix/deposit-withdraw-header-perps

aganglada commented Apr 8, 2026 •

edited by cursor bot

Loading

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Uh oh!

metamaskbotv2 bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

aganglada commented Apr 8, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

metamaskbotv2 bot commented Apr 8, 2026

Uh oh!

sonarqubecloud bot commented Apr 9, 2026

Quality Gate passed

Uh oh!

metamaskbotv2 bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

aganglada commented Apr 8, 2026 •

edited by cursor bot

Loading

metamaskbotv2 bot commented Apr 8, 2026 •

edited

Loading