Skip to content

ci: use deployment: false for integration test environments#712

Merged
salmanmkc merged 2 commits intomainfrom
salmanmkc/deployment-false
Apr 9, 2026
Merged

ci: use deployment: false for integration test environments#712
salmanmkc merged 2 commits intomainfrom
salmanmkc/deployment-false

Conversation

@salmanmkc
Copy link
Copy Markdown
Contributor

Uses deployment: false on the debug integration test environment reference to suppress deployment records from cluttering PR timelines.

The debug-integration-test environment is only used to set runner.debug = true — no actual deployment is involved. Adding deployment: false keeps access to environment secrets and protection rules while preventing unnecessary deployment objects and webhook noise.

environment:
  name: debug-integration-test
  deployment: false

Copilot AI review requested due to automatic review settings April 9, 2026 19:03
@salmanmkc salmanmkc requested a review from a team as a code owner April 9, 2026 19:03
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Hello from actions/github-script! (07a8b16)

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the integration workflow to mark the debug-integration-test environment usage as non-deployment, aiming to reduce noisy deployment records while still applying environment protections/secrets.

Changes:

  • Switches the test-debug job’s environment from a string to an object with name.
  • Adds deployment: false to suppress deployment records for the environment reference.
Show a summary per file
File Description
.github/workflows/integration.yml Adjusts the test-debug job’s environment configuration to use deployment: false.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines +181 to +183
environment:
name: ${{ matrix.environment }}
deployment: false
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matrix.environment includes an empty string, but the new object form always sets environment.name. If matrix.environment resolves to '', this can yield an empty environment name and cause the workflow to error (and/or attempt to reference a non-existent environment). Consider conditionally omitting environment when the matrix value is empty (e.g., make environment itself an expression that returns '' for the non-debug case, or restructure the matrix to use a boolean and only set the environment for the debug variant).

Suggested change
environment:
name: ${{ matrix.environment }}
deployment: false
environment: ${{ matrix.environment && fromJSON(format('{{"name":"{0}","deployment":false}}', matrix.environment)) || '' }}

Copilot uses AI. Check for mistakes.
@salmanmkc salmanmkc merged commit afff112 into main Apr 9, 2026
14 checks passed
@salmanmkc salmanmkc deleted the salmanmkc/deployment-false branch April 9, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants