ci: use deployment: false for integration test environments#712
ci: use deployment: false for integration test environments#712
Conversation
|
Hello from actions/github-script! (07a8b16) |
There was a problem hiding this comment.
Pull request overview
Updates the integration workflow to mark the debug-integration-test environment usage as non-deployment, aiming to reduce noisy deployment records while still applying environment protections/secrets.
Changes:
- Switches the
test-debugjob’senvironmentfrom a string to an object withname. - Adds
deployment: falseto suppress deployment records for the environment reference.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/integration.yml | Adjusts the test-debug job’s environment configuration to use deployment: false. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| environment: | ||
| name: ${{ matrix.environment }} | ||
| deployment: false |
There was a problem hiding this comment.
matrix.environment includes an empty string, but the new object form always sets environment.name. If matrix.environment resolves to '', this can yield an empty environment name and cause the workflow to error (and/or attempt to reference a non-existent environment). Consider conditionally omitting environment when the matrix value is empty (e.g., make environment itself an expression that returns '' for the non-debug case, or restructure the matrix to use a boolean and only set the environment for the debug variant).
| environment: | |
| name: ${{ matrix.environment }} | |
| deployment: false | |
| environment: ${{ matrix.environment && fromJSON(format('{{"name":"{0}","deployment":false}}', matrix.environment)) || '' }} |
Uses
deployment: falseon the debug integration test environment reference to suppress deployment records from cluttering PR timelines.The
debug-integration-testenvironment is only used to setrunner.debug = true— no actual deployment is involved. Addingdeployment: falsekeeps access to environment secrets and protection rules while preventing unnecessary deployment objects and webhook noise.