Skip to content

fix(@angular/build): allow configuring Access-Control-Allow-Origin via headers option #32976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alan-agius4 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

fix(@angular/build): allow configuring Access-Control-Allow-Origin via headers option #32976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/angular/build/src/builders/dev-server/tests/options/headers_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,20 @@ describeServeBuilder(executeDevServer, DEV_SERVER_BUILDER_INFO, (harness, setupT
expect(await response?.headers.get('x-custom')).toBe('foo');
});

it('should include configured Access-Control-Allow-Origin header', async () => {
Copy link
Copy Markdown
Collaborator

@dgp1130 dgp1130 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider: Should we add a test that the CORS header is not returned by default?

harness.useTarget('serve', {
...BASE_OPTIONS,
headers: {
'Access-Control-Allow-Origin': 'http://example.com',
},
});

const { result, response } = await executeOnceAndFetch(harness, '/main.js');

expect(result?.success).toBeTrue();
expect(await response?.headers.get('access-control-allow-origin')).toBe('http://example.com');
});

it('media resource response headers should include configured header', async () => {
await harness.writeFiles({
'src/styles.css': `h1 { background: url('./test.svg')}`,
Expand Down
3 changes: 0 additions & 3 deletions packages/angular/build/src/builders/dev-server/vite/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ async function createServerConfig(
ws: serverOptions.liveReload === false && serverOptions.hmr === false ? false : undefined,
proxy,
cors: {
// This will add the header `Access-Control-Allow-Origin: http://example.com`,
// where `http://example.com` is the requesting origin.
origin: true,
// Allow preflight requests to be proxied.
preflightContinue: true,
},
Expand Down
Loading