Skip to content

Feature/79 fix vendor plugins#80

Merged
dereuromark merged 4 commits intocakephp:2.xfrom
steinkel:feature/79-fix-vendor-plugins
Apr 10, 2026
Merged

Feature/79 fix vendor plugins#80
dereuromark merged 4 commits intocakephp:2.xfrom
steinkel:feature/79-fix-vendor-plugins

Conversation

@steinkel
Copy link
Copy Markdown
Member

@steinkel steinkel commented Apr 9, 2026

fixes #79

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.11%. Comparing base (c2b62ee) to head (781496b).
⚠️ Report is 5 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #80      +/-   ##
============================================
+ Coverage     77.51%   82.11%   +4.59%     
- Complexity       42       48       +6     
============================================
  Files             1        1              
  Lines           129      151      +22     
============================================
+ Hits            100      124      +24     
+ Misses           29       27       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereuromark
Copy link
Copy Markdown
Member

dereuromark commented Apr 9, 2026

  • I’d consider extracting the “scan app plugins, supporting flat + vendor/plugin layout” logic into a small shared helper, because the same traversal rules now live in two places.
  • I’d maybe add one more explicit test for the fallback behavior in findPlugins() when a top-level directory has no src/ and no nested plugin children, just to document why that legacy behavior is kept.

If you want, I can add a commit on top here.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dereuromark dereuromark requested review from ADmad and LordSimal April 9, 2026 13:28
Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dereuromark dereuromark merged commit 40bfecb into cakephp:2.x Apr 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

preAutoloadDump doesn't handle vendor-namespaced app plugins (Vendor/Plugin)

3 participants