removed SuppressionList::Suppression::NO_LINE#8429
Draft
firewave wants to merge 1 commit intodanmar:mainfrom
Draft
removed SuppressionList::Suppression::NO_LINE#8429firewave wants to merge 1 commit intodanmar:mainfrom
SuppressionList::Suppression::NO_LINE#8429firewave wants to merge 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
This is mostly likely the reason why lines are signed in Cppcheck but unsigned in simplecpp. This will be resolved in a follow-up. |
firewave
force-pushed
the
suppr-no-line
branch
4 times, most recently
from
06a2c35 to
0e43d67
Compare
The suppressions were using `-1` as indication that no line is used but in simplecpp `0` was used for that.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suppressions were using
-1as indication that no line is used but in simplecpp0is used for that.