Docker Login not just for push?

[mathieu-benoit]

Contributing guidelines

• I've read the contributing guidelines and wholeheartedly agree

I've found a bug, and:

• The documentation does not mention anything about my problem
• There are no open or closed issues that are related to my problem

Description

In my Dockerfile, I have a base image in a private registry, I found out that even if I supply the secrets.registry-auths the Docker Login step is skipped because of if: ${{ inputs.push...: https://github.com/docker/github-builder/blob/main/.github/workflows/build.yml#L598.

I'm in a PR, with push: false.

Is that on purpose? Meaning we cannot build a container having base images in a private registry when we don't push?

Expected behaviour

It would be great to have the Docker Login with push: false.

Actual behaviour

Docker Login is skipped because push: false.

Repository URL

https://github.com/mathieu-benoit/deploy-backstage-with-score

Workflow run URL

https://github.com/mathieu-benoit/deploy-backstage-with-score/blob/dhi/.github/workflows/ci.yaml

YAML workflow

https://github.com/mathieu-benoit/deploy-backstage-with-score/blob/dhi/.github/workflows/ci.yaml

[crazy-max]

Yes this is similar to #97

[mathieu-benoit]

Indeed, closing this one as duplicate and already tracked there #97, thanks!