Skip to content

refactor(1/12): remove deprecated logging tools#319

Merged
cameroncooke merged 2 commits intomainfrom
refactor/remove-logging-tools
Apr 9, 2026
Merged

refactor(1/12): remove deprecated logging tools#319
cameroncooke merged 2 commits intomainfrom
refactor/remove-logging-tools

Conversation

@cameroncooke
Copy link
Copy Markdown
Collaborator

Summary

This is PR 1 of 12 in a stacked PR series that decouples the rendering pipeline from MCP transport. This PR can be reviewed and merged independently.

Removes all deprecated logging tools that were superseded by the unified log capture approach. These tools (start_sim_log_cap, stop_sim_log_cap, start_device_log_cap, stop_device_log_cap, launch_app_logs_sim) used a start/stop session model that was fragile and leaked resources. The replacement (already shipped in earlier releases) integrates log capture directly into build-and-run workflows, making these standalone logging tools dead code.

What changes

  • Delete all 4 logging tool implementations and their tests (src/mcp/tools/logging/)
  • Delete launch_app_logs_sim tool (simulator variant that combined launch + log capture)
  • Remove corresponding YAML manifests and the logging workflow manifest
  • Remove logging tool references from device and simulator workflow manifests
  • Delete the e2e smoke test for logging tools

Why

These tools have been deprecated since the log capture was integrated into build-run workflows. Removing them before the rendering pipeline refactor avoids migrating dead code to the new handler contract, keeping subsequent PRs in this stack cleaner.

Stack navigation

  • PR 1/12 (this PR): Remove deprecated logging tools
  • PR 2/12: Pipeline event types, parsers, and event builders
  • PR 3/12: Rendering engine and output formatting
  • PR 4/12: Build/test utility extraction, platform steps, xcodebuild pipeline
  • PR 5/12: Runtime handler contract and tool invoker
  • PR 6/12: Tool migrations - Simulator tools
  • PR 7/12: Tool migrations - Device + macOS tools
  • PR 8/12: Tool migrations - UI automation tools
  • PR 9/12: Tool migrations - Remaining tools
  • PR 10/12: CLI, daemon, and MCP server boundaries
  • PR 11/12: Manifests, config, docs, and examples
  • PR 12/12: Snapshot test fixtures and benchmarks

Test plan

  • npx vitest run passes (no tests reference removed tools)
  • No remaining imports of deleted modules in the codebase
  • Manifest validation passes without the removed YAML files

@cameroncooke cameroncooke force-pushed the refactor/remove-logging-tools branch from 585faf0 to 9a660e0 Compare April 8, 2026 21:29
The docs check was failing because docs/CLI.md still referenced the
deleted logging CLI commands (start-simulator-log-capture,
stop-simulator-log-capture).
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 9, 2026

Open in StackBlitz

npm i https://pkg.pr.new/xcodebuildmcp@319

commit: d820dcf

@cameroncooke cameroncooke merged commit 1ba6b76 into main Apr 9, 2026
12 checks passed
@cameroncooke cameroncooke deleted the refactor/remove-logging-tools branch April 9, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant