refactor: replace Split in loops with more efficient SplitSeq#22494
Merged
chlins merged 1 commit intogoharbor:mainfrom Oct 24, 2025
Merged
refactor: replace Split in loops with more efficient SplitSeq#22494chlins merged 1 commit intogoharbor:mainfrom
chlins merged 1 commit intogoharbor:mainfrom
Conversation
Signed-off-by: rustversion <rustverion@outlook.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22494 +/- ##
===========================================
+ Coverage 45.36% 65.84% +20.47%
===========================================
Files 244 1073 +829
Lines 13333 116106 +102773
Branches 2719 2931 +212
===========================================
+ Hits 6049 76446 +70397
- Misses 6983 35423 +28440
- Partials 301 4237 +3936
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
OrlinVasilev
pushed a commit
to OrlinVasilev/harbor
that referenced
this pull request
Oct 29, 2025
…or#22494) Signed-off-by: rustversion <rustverion@outlook.com>
vg006
pushed a commit
to vg006/harbor
that referenced
this pull request
Dec 4, 2025
…or#22494) Signed-off-by: rustversion <rustverion@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
strings.SplitSeq (introduced in Go 1.23) returns a lazy sequence (strings.Seq), allowing gopher to iterate over tokens one by one without creating an intermediate slice.
More info: golang/go#61901
Please indicate you've done the following: