Skip to content

refactor: replace Split in loops with more efficient SplitSeq#22494

Merged
chlins merged 1 commit intogoharbor:mainfrom
rustversion:main
Oct 24, 2025
Merged

refactor: replace Split in loops with more efficient SplitSeq#22494
chlins merged 1 commit intogoharbor:mainfrom
rustversion:main

Conversation

@rustversion
Copy link
Copy Markdown
Contributor

@rustversion rustversion commented Oct 24, 2025

Comprehensive Summary of your change

strings.SplitSeq (introduced in Go 1.23) returns a lazy sequence (strings.Seq), allowing gopher to iterate over tokens one by one without creating an intermediate slice.

More info: golang/go#61901

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: rustversion <rustverion@outlook.com>
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/update Update or Fix label Oct 24, 2025
@chlins chlins enabled auto-merge (squash) October 24, 2025 07:21
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (ab1a8ac).
⚠️ Report is 580 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22494       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116106   +102773     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76446    +70397     
- Misses       6983    35423    +28440     
- Partials      301     4237     +3936     
Flag Coverage Δ
unittests 65.84% <100.00%> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/registry/controller.go 29.52% <100.00%> (ø)

... and 986 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 01f848e into goharbor:main Oct 24, 2025
13 of 14 checks passed
OrlinVasilev pushed a commit to OrlinVasilev/harbor that referenced this pull request Oct 29, 2025
vg006 pushed a commit to vg006/harbor that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/update Update or Fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants