Skip to content

Fix redis sentinel master acl for jobservice#22765

Merged
wy65701436 merged 1 commit intogoharbor:mainfrom
MinerYang:fix-jobservice-acl
Jan 23, 2026
Merged

Fix redis sentinel master acl for jobservice#22765
wy65701436 merged 1 commit intogoharbor:mainfrom
MinerYang:fix-jobservice-acl

Conversation

@MinerYang
Copy link
Copy Markdown
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(#22310)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.88%. Comparing base (c8c11b4) to head (ec05d66).
⚠️ Report is 635 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/redis/pool.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22765       +/-   ##
===========================================
+ Coverage   45.36%   65.88%   +20.51%     
===========================================
  Files         244     1074      +830     
  Lines       13333   116363   +103030     
  Branches     2719     2932      +213     
===========================================
+ Hits         6049    76665    +70616     
- Misses       6983    35456    +28473     
- Partials      301     4242     +3941     
Flag Coverage Δ
unittests 65.88% <0.00%> (+20.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/redis/pool.go 14.52% <0.00%> (ø)

... and 988 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 enabled auto-merge (squash) January 22, 2026 07:25
Copy link
Copy Markdown
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang force-pushed the fix-jobservice-acl branch 2 times, most recently from fdcfbfe to f08287e Compare January 22, 2026 07:33
@MinerYang MinerYang changed the title fix redis sentinel master acl for jobservice Fix redis sentinel master acl for jobservice Jan 22, 2026
@MinerYang MinerYang force-pushed the fix-jobservice-acl branch 3 times, most recently from 7e0b8fa to ca4cf08 Compare January 22, 2026 17:04
Signed-off-by: my036811 <miner.yang@broadcom.com>
@wy65701436 wy65701436 merged commit c6fd717 into goharbor:main Jan 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants