chore(spanner): add ReplicaSelector interface and impl#12728
Open
chore(spanner): add ReplicaSelector interface and impl#12728
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ReplicaSelector interface and its implementation, PowerOfTwoReplicaSelector, which selects a replica from a list of candidates using a "Power of 2 Random Choices" strategy based on their scores. Comprehensive unit tests are also included for this new functionality. The review feedback suggests a simplification for the random index selection logic within the PowerOfTwoReplicaSelector to enhance readability.
...e-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/PowerOfTwoReplicaSelector.java
Show resolved
Hide resolved
Adds a ReplicaSelector interface and a default implementation for a ReplicaSelector that uses the power-of-2-random-choices selection strategy. Other strategies can be implemented in the future.
olavloite
force-pushed
the
spanner-replica-selector
branch
from
dc3fd84 to
556d357
Compare
rahul2393
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ReplicaSelector interface and a default implementation for a ReplicaSelector that uses the power-of-2-random-choices selection strategy. Other strategies can be implemented in the future.