Skip to content

updateOptions() fixes for columnOpts, maxRow#3237

Merged
adumesny merged 1 commit intogridstack:masterfrom
adumesny:master
Mar 3, 2026
Merged

updateOptions() fixes for columnOpts, maxRow#3237
adumesny merged 1 commit intogridstack:masterfrom
adumesny:master

Conversation

@adumesny
Copy link
Copy Markdown
Member

@adumesny adumesny commented Mar 3, 2026

Description

  • make sure we update resizeEvent if adding columnOpts
  • fix to carry maxRow to engine (has static copy)

Also

  • load() no longer clones the passed in data, which enables callee to control what structures are being used.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* make sure we update resizeEvent if adding columnOpts
* fix to carry maxRow to engine (has static copy)

Also
* load() no longer clones the passed in data, which enables callee to control what structures are being used.
@adumesny adumesny merged commit 9b4dab5 into gridstack:master Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant