Python: fix(bedrock): don't send toolChoice when no tools are configured#5172
Open
Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Open
Python: fix(bedrock): don't send toolChoice when no tools are configured#5172Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Bahtya wants to merge 1 commit intomicrosoft:mainfrom
Conversation
BedrockChatClient was sending toolConfig.toolChoice even when no tools were configured (tools=None). AWS Bedrock requires toolConfig.tools to be present whenever toolChoice is specified, causing a 400 validation error. Only set toolChoice when tool_config has a 'tools' key present. Fixes microsoft#5165 Signed-off-by: bahtya <bahtyar153@qq.com>
github-actions
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
BedrockChatClientwith anAgentthat has no tools configured, the client still sendstoolConfig.toolChoiceto the Bedrock API. AWS Bedrock requirestoolConfig.toolsto be present whenevertoolChoiceis specified, causing a 400 validation error.Root Cause
In
_prepare_run_options, whentool_choiceis set but_prepare_toolsreturnsNone(no tools), the code creates an empty dict withtool_config or {}and addstoolChoiceto it. This results in sending{"toolChoice": {"auto": {}}}without anytoolskey.Fix
Only set
toolChoicewhentool_configis not None and has a"tools"key. When no tools are configured,toolChoiceis silently skipped.Fixes #5165