Skip to content

module: add isBuiltin method#43396

Merged
nodejs-github-bot merged 24 commits intonodejs:mainfrom
hemanth:util-is-builtin
Jul 8, 2022
Merged

module: add isBuiltin method#43396
nodejs-github-bot merged 24 commits intonodejs:mainfrom
hemanth:util-is-builtin

Conversation

@hemanth
Copy link
Copy Markdown
Contributor

@hemanth hemanth commented Jun 13, 2022 •
edited by aduh95
Loading

Exposing isBuiltinModule methods on util/types if we decide to have this, should it be here or directly on util?

@nodejs/util

Yes, it can be a simple includes check, but there are many npm packages with stats like below to do the same:

image

Fixes: #42785

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@juanarbol juanarbol juanarbol approved these changes

@ljharb ljharb Awaiting requested review from ljharb

+4 more reviewers

@mscdex mscdex mscdex left review comments

@devsnek devsnek devsnek left review comments

@F3n67u F3n67u F3n67u requested changes

@antsmartian antsmartian antsmartian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

no way to programmatically discover node:test