fix: allow subsecond precision beyond 9 digits in ISO 8601 parser#959
Closed
JKDasondee wants to merge 2 commits intopython-pendulum:masterfrom
Closed
fix: allow subsecond precision beyond 9 digits in ISO 8601 parser#959JKDasondee wants to merge 2 commits intopython-pendulum:masterfrom
JKDasondee wants to merge 2 commits intopython-pendulum:masterfrom
Conversation
Collaborator
|
Same as #960, weird mixture of commits. Please, clean up your patch and provide tests for the changed code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #935
The ISO 8601 regex restricts subsecond digits to
\d{1,9}, causingParserErrorfor timestamps with 10+ fractional digits. Since the subsecond value is already truncated to 6 characters (subsecond[:6]) before conversion, the regex limit is the only blocker. Changed\d{1,9}to\d+to match what Python's ownfromisoformataccepts.