Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recent
--purgesupport added parser and execution coverage forrc rm, but the noun-firstrc object removeentrypoint reuses the sameRmArgswithout dedicated parser coverage.This change adds one focused parser test in
crates/cli/src/commands/mod.rsto verify thatrc object remove local/my-bucket/object.txt --purgeis accepted and setspurge = trueon the delegated remove args.User impact
Without this test, a regression in the noun-first parser path could silently break
object remove --purgewhilerm --purgekept passing. Users relying on the object-oriented command surface would lose the new flag behavior without a targeted signal in CI.Validation
I first ran the focused parser test:
cargo test cli_accepts_object_remove_with_purge_flagThe repository does not define
make pre-commit, so that target cannot be run in this checkout. I ran the CI-equivalent checks from.github/workflows/ci.ymlinstead:cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace