Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds focused parser coverage for deprecated top-level command aliases introduced in the recent bucket CORS and event work.
Problem
The recent command surface expansion added deprecated top-level
rc corsandrc evententry points alongside the nestedrc bucket ...forms. Existing tests already covered the nested bucket forms and one top-levelcors removecase, but two parser paths were still untested:rc cors get <alias/bucket>should resolve to theListcommand through thegetalias.rc event list <alias/bucket>should continue to parse through the deprecated top-level entry point.Without direct assertions, a future clap refactor could silently break these compatibility paths while leaving adjacent tests green.
Fix
The patch adds two small command parser tests in
crates/cli/src/commands/mod.rs:cli_accepts_top_level_cors_get_aliascli_accepts_top_level_event_subcommandThe production code is unchanged. The diff is intentionally limited to command-surface tests around the recently added aliases.
Validation
make pre-commitis not available in this checkout because the repository does not define apre-committarget.The branch was validated with:
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace