Adjust new task button to create new task #4063
+113
−95
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import { useCallback, useEffect, useMemo, useRef, useState } from 'react' | ||
| import { createLogger } from '@sim/logger' | ||
| import { useQueryClient } from '@tanstack/react-query' | ||
| import { useRouter } from 'next/navigation' | ||
| import { | ||
| cancelRunToolExecution, | ||
| executeRunToolOnClient, | ||
|
|
@@ -65,6 +65,7 @@ import type { WorkflowMetadata } from '@/stores/workflows/registry/types' | |
|
|
||
| export interface UseChatReturn { | ||
| messages: ChatMessage[] | ||
| isHistoryReady: boolean | ||
| isSending: boolean | ||
| isReconnecting: boolean | ||
| error: string | null | ||
|
|
@@ -410,7 +411,7 @@ export function useChat( | |
| initialChatId?: string, | ||
| options?: UseChatOptions | ||
| ): UseChatReturn { | ||
| const router = useRouter() | ||
| const queryClient = useQueryClient() | ||
| const [messages, setMessages] = useState<ChatMessage[]>([]) | ||
| const [isSending, setIsSending] = useState(false) | ||
|
|
@@ -506,7 +507,6 @@ export function useChat( | |
| const streamingBlocksRef = useRef<ContentBlock[]>([]) | ||
| const clientExecutionStartedRef = useRef<Set<string>>(new Set()) | ||
| const executionStream = useExecutionStream() | ||
|
|
||
| const { data: chatHistory } = useChatHistory(initialChatId) | ||
|
|
||
|
|
@@ -595,32 +595,6 @@ export function useChat( | |
| setPendingRecoveryMessage(null) | ||
| }, [initialChatId, queryClient]) | ||
|
|
||
| const fetchStreamBatch = useCallback( | ||
| async ( | ||
| streamId: string, | ||
|
|
@@ -895,7 +869,10 @@ export function useChat( | |
|
|
||
| if (isNewChat) { | ||
| applyChatHistorySnapshot(chatHistory, { preserveActiveStreamingMessage: true }) | ||
| } else if (sendingRef.current) { | ||
| return | ||
| } else if (!activeStreamId) { | ||
| applyChatHistorySnapshot(chatHistory) | ||
| return | ||
| } | ||
|
|
||
|
|
@@ -1119,11 +1096,9 @@ export function useChat( | |
| }) | ||
| } | ||
| if (!workflowIdRef.current) { | ||
| router.replace(`/workspace/${workspaceId}/task/${parsed.chatId}`) | ||
| abortControllerRef.current?.abort() | ||
| streamGenRef.current++ | ||
|
There was a problem hiding this comment. Router navigation aborts active SSE message streamMedium Severity Replacing   Reviewed by Cursor Bugbot for commit 2ba89a7. Configure here. |
||
| } | ||
| } | ||
| } | ||
|
|
@@ -2106,6 +2081,7 @@ export function useChat( | |
| [ | ||
| workspaceId, | ||
| queryClient, | ||
| router, | ||
| processSSEStream, | ||
| finalize, | ||
| resumeOrFinalize, | ||
|
|
@@ -2282,8 +2258,11 @@ export function useChat( | |
| } | ||
| }, []) | ||
|
|
||
| const isHistoryReady = !initialChatId || chatHistory !== undefined | ||
|
|
||
| return { | ||
| messages, | ||
| isHistoryReady, | ||
| isSending, | ||
| isReconnecting, | ||
| error, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greeting screen flashes on task page navigation
Medium Severity
The condition changed from
!hasMessages && !chatIdto!hasMessages && isHistoryReady. Themessagesstate is initialized as[]viauseStateand only populated fromchatHistoryvia auseEffectthat runs after the render. When navigating to a task page with existing messages,isHistoryReadybecomestrue(cache hit) before the effect populatesmessages, so for at least one render frame!hasMessages && isHistoryReadyevaluates totrue, causing the "What should we get done?" greeting to flash. The old!chatIdguard prevented this becausechatIdis always set on the task page.Additional Locations (1)
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts#L2260-L2261Reviewed by Cursor Bugbot for commit 2ba89a7. Configure here.