Skip to content

feat(publish-helm-chart): Add merge-registry-values toggle#100

Merged
Techassi merged 7 commits intomainfrom
feat/publish-helm-chart-merge-registry-values
Apr 9, 2026
Merged

feat(publish-helm-chart): Add merge-registry-values toggle#100
Techassi merged 7 commits intomainfrom
feat/publish-helm-chart-merge-registry-values

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Apr 7, 2026

Part of stackabletech/issues#716.

This PR adds a toggle to merge a registry-specific values file with the core/common one. Merging can be verified by running:

$ helm show values oci://oci.stackable.tech/smoke/helm-chart
Pulled: oci.stackable.tech/smoke/helm-chart:0.0.2
Digest: sha256:12ed28620a7443a7fe3ac71b0ac906e0ccdfb7c11cd29c2f27eb9b23384961fb
---
image:
  registry: oci.stackable.tech
  repository: smoke/helm-chart

Checking included files (and making sure the values directory is not included) can be done with:

$ helm pull oci://oci.stackable.tech/smoke/helm-chart --untardir showmeboi --untar
Pulled: oci.stackable.tech/smoke/helm-chart:0.0.2
Digest: sha256:12ed28620a7443a7fe3ac71b0ac906e0ccdfb7c11cd29c2f27eb9b23384961fb

$ tree showmeboi
showmeboi
└── helm-chart
    ├── Chart.yaml
    └── values.yaml

2 directories, 2 files

@Techassi Techassi self-assigned this Apr 7, 2026
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Apr 7, 2026
@Techassi Techassi marked this pull request as ready for review April 7, 2026 15:36
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 7, 2026
@Techassi Techassi requested review from NickLarsenNZ and razvan April 7, 2026 15:36
@Techassi Techassi changed the title feat(publish-helm-chart): Add merge registry values toggle feat(publish-helm-chart): Add merge-registry-values toggle Apr 7, 2026
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi merged commit 25622e7 into main Apr 9, 2026
12 checks passed
@Techassi Techassi deleted the feat/publish-helm-chart-merge-registry-values branch April 9, 2026 11:13
@Techassi Techassi moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants